Rails Best Practices

You could also do it in only one single line:

def create
    @post = current_user.posts.create(params[:post])
end

If i'm using the suggested way for assigning @post, how the functional test should be? I'm using rspec and this is what I would normally do if I use @post = Post.new(params[:post]):

  def mock_post(stubs={})
    (@mock_post ||= mock_model(Post).as_null_object).tap do |post|
      post.stub(stubs) unless stubs.empty?
    end
  end

  #...

  describe "POST create" do
    it "assigns a newly created post as @post" do
      Post.stub(:new).with({'these' => 'params'}) { mock_post(:save => true) }
      # ...
    end
  end

Thanks

Assume you have multiple has_many relationships in your model. What's best practise for creating model then ?

For example, let's say you have models Article, User and Group.

class Article < ActiveRecord::Base
  belongs_to :user
  belongs_to :subdomain
end

class User < ActiveRecord::Base
  has_many :articles
end

class Subdomain < ActiveRecord::Base
  has_many :subdomain
end

and ArticlesController:

class ArticlesController < ApplicationController
  def create
    # let's say we have methods current_user which returns current user and current_subdomain which gets current subdomain
    # so, what I need here is a way to set subdomain_id to current_subdomain.id and user_id to current_user.id
    @article = current_user.build(params[:article])
    @article.subdomain_id = current_subdomain.id
    @article.save
  end
end

Is there a cleaner way ?

In Rails 3 You can use scopes to do this. Like:
@article=current_user.articles_with_subdomain(current_subdomain).build(param[:article])
Might seem cumbersome on a first sight. Anyway you should see Advanced Queries in Rails 3. IMHO nice way to build such models.

For multi associations, like in mfolnovic example:

[code]
@article = current_user.build(params[:article], :subdomain_id => current_subdomain.id)
[/code]

Hello, i read your site, this a best site from me, thanks!

I agree with @karmeliet

But we have a mass assignment security problem with this pattern. Because you can pass pos[user_id] as param. So, my solutions is:

def create
    @post = current_user.posts.create(params[:post].except(:user_id)
end