Posted by
ihower
on
July 24, 2010
According to MVC architecture, there should not be logic codes in view, in this practice, I will introduce you to move codes into helper.
Bad Smell
<%= select_tag :state, options_for_select( [[t(:draft), "draft"],
[t(:published), "published"]],
params[:default_state] ) %>
The options for state select is a bit complex in view, let's move it into helper.
Refactor
<%= select_tag :state, options_for_post_state(params[:default_state]) %>
# app/helpers/posts_helper.rb
def options_for_post_state(default_state)
options_for_select( [[t(:draft), "draft"], [t(:published), "published"]],
default_state )
end
The view code is clean now, we can just call the helper method to load all needed options.
Comments
first try to use default ones
if you repeat the same code a lot - write helper
but don't you dare to generate your views with ton of different helpers for SIMILAR things - it's a sign of bad architecture of whole task
Writing helper just to make the code more readable is not a good practice as you will end up writing too much of helper methods.