use OpenStruct when advance search

Posted by alvin2ye on August 25, 2010

use OpenStruct when advance search

Before

in view

<% form_for_tag blabal do |f| %> 
  <%= f.text_field_tag :quick, params[:search][:quick] %> 
 <%= select_tag("country", options_for_select([["unassigned" , "0" ]] +
                  Country.to_dropdown, region.country_id),
                  {:name => "search[country]"} ) %>
  <%= f.submit "Search" %> 
<% end %>

After

in controller

require 'ostruct' 

def index 
  @search = OpenStruct.new(params[:search]) 
end

in view

<% form_for :search, :url => {:action => "index"}, :html => {:method => :get} do |f| %> 
  <%= f.text_field :quick %> 
  <%= f.select :quick, Country.to_dropdown %> 
  <%= f.submit "Search" %> 
<% end %>

search view

<< Fetch current user in models

Put scripts at the bottom >>

related best practices:

Comments

Posted by yorzi on 2010-09-06T08:45:58Z

Wondering what's the advantage of doing advance search in this way.

Posted by flyerhzm on 2010-09-06T09:06:52Z

@andy, I think the advantage of using openstruct is that you can use form_for helper instead of form_tag, f.text_field instead of text_field_tag and other form related helpers.

Posted by 3dd13 on 2010-09-13T09:46:04Z

@andy, using OpenStruct could save you few lines of code to transform the hash into an object.

it cleans up your code too, you dont' have to specify the hash key everywhere repeatedly in your code.

to me, it is more object-oriented-looking.

Posted by knightq on 2011-02-28T08:00:26Z

Why don't you post a differential example which help a newbie as me to better understand the real value of this best practice, as other users do?
It would be great if you could modify this post into something like this:

Before
...

After
...

I miss the "Before" section...

Posted by alvin2ye on 2011-03-12T03:15:17Z

@knightq updated for you

Posted by Andy on 2011-10-05T07:34:05Z

Aslo you can use tableless model - this way you've got validations for your form:

class Tableless
  include ActiveModel::Validations
  include ActiveModel::Conversion
  extend ActiveModel::Naming

  def initialize(props = {})
    props.each do |name, value|
      send("#{name}=", value)
    end
  end

  def persisted?
    false
  end
end

class Search < Tableless
  validates :quick, :presence => true
end

def index 
  @search = Search.new(params[:search]) 
end

Rails Best Practices

use OpenStruct when advance search

in view

in controller

in view

Comments

Service

Sponsors

Top Ruby and Rails Jobs

Navigator

Tags